Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sendEncodings in RTCRtpTransceiverInit #3642

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Add sendEncodings in RTCRtpTransceiverInit #3642

merged 2 commits into from
Oct 5, 2023

Conversation

logist322
Copy link
Contributor

This PR adds spec compliant sendEncodings field in RTCRtpTransceiverInit.

daxpedda
daxpedda requested changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a note in the changelog?
Otherwise LGTM, thank you!

@daxpedda daxpedda added the waiting for author Waiting for author to respond label Oct 5, 2023
@logist322 logist322 requested a review from daxpedda October 5, 2023 13:32
daxpedda
daxpedda approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Just waiting for CI.

@daxpedda daxpedda removed the waiting for author Waiting for author to respond label Oct 5, 2023
@daxpedda daxpedda merged commit 5d0f935 into rustwasm:main Oct 5, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@logist322 @daxpedda